Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependencies from td-tool package #1312

Merged
merged 11 commits into from
Aug 8, 2024
Merged

Remove dependencies from td-tool package #1312

merged 11 commits into from
Aug 8, 2024
+1,752 −222

Conversation

danielpeintner
Copy link
Member

@danielpeintner danielpeintner commented Jul 24, 2024 •
edited
Loading

TODOs

  • Helpers in core still has import { Resolver } from "@node-wot/td-tools/src/resolver-interface"; which cannot be removed until @thingweb/thing-model exports Resolver (see Exporting the Resolver Interface td-tools#35). Causes eslint issue in CI pipeline (resolved by 9e1f6f0)
  • add SerDes tests (resolved by 512288d)
  • Check examples, readmes etc whether td-tools is still mentioned/used

fixes #1311

@danielpeintner danielpeintner mentioned this pull request Jul 25, 2024
Merged
@danielpeintner danielpeintner marked this pull request as draft July 25, 2024 12:22
@danielpeintner danielpeintner marked this pull request as ready for review July 29, 2024 13:56
@danielpeintner
Copy link
Member Author

danielpeintner commented Jul 29, 2024 •
edited
Loading

The PR is now ready for review. With the changes we can be removing the td-tools package once needed (there is no dependency anymore).

@danielpeintner
Copy link
Member Author

Anyone willing to review?

There is no real technical change.... it moves necessary functionality from td-tools to core and removes in all packages the dependency to td-tools

egekorkan
egekorkan approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@egekorkan egekorkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine and the changes seem mostly mechanical and copy-paste

relu91
relu91 approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the question below the changes are ok!

packages/core/src/thing-description.ts Outdated Show resolved Hide resolved
@danielpeintner
refactor: remove "own" definition of ThingModel
8c1e059 
use the one from "wot-thing-model-types"
@relu91 relu91 merged commit 915c111 into eclipse-thingweb:master Aug 8, 2024
13 checks passed
@danielpeintner danielpeintner mentioned this pull request Aug 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egekorkan egekorkan egekorkan approved these changes

@relu91 relu91 relu91 approved these changes

@JKRhb JKRhb Awaiting requested review from JKRhb JKRhb is a code owner

@mkovatsc mkovatsc Awaiting requested review from mkovatsc mkovatsc is a code owner

@sebastiankb sebastiankb Awaiting requested review from sebastiankb sebastiankb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PR to tackle the refactoring of duplicating thing-description.ts to core
3 participants
@danielpeintner @relu91 @egekorkan